Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows local run + log clarifications #1054

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

jonaro00
Copy link
Member

Description of change

Fixes more Windows issues discovered here https://discord.com/channels/803236282088161321/1122643649503694919

  • Added more timeout to the runtime wait.
  • The stopped_tx send calls are now ignored if they fail, because there is only a subscriber in deployment.

How has this been tested? (if applicable)

No further proof than Samarth's code working.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few suggestions for tracing calls

runtime/src/alpha/mod.rs Outdated Show resolved Hide resolved
runtime/src/alpha/mod.rs Outdated Show resolved Hide resolved
proto/src/lib.rs Show resolved Hide resolved
runtime/src/alpha/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

proto/src/lib.rs Show resolved Hide resolved
@oddgrd oddgrd merged commit 63bcf8f into shuttle-hq:main Jun 27, 2023
29 checks passed
@oddgrd oddgrd added B-Shuttle Batch Submitted by a Shuttle Batch participant XS labels Jun 27, 2023
@jonaro00 jonaro00 deleted the fix/windows-local-run branch June 27, 2023 09:25
AlphaKeks pushed a commit to AlphaKeks/shuttle that referenced this pull request Jul 21, 2023
* fix: windows local run + log clarifications

* error!

* trace the errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-Shuttle Batch Submitted by a Shuttle Batch participant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants