fix: broken gateway pagination and status check tests #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
approved these changes
Jul 10, 2023
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* fix: broken gateway tests * refactor: clean up status check test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When testing h2 project support, I discovered some broken gateway tests. These have (understandably) slipped through since we don't run them in CI, which is the bigger problem here. 😄 The status test was not updated to reflect the changes we made to the gateway status check for the shuttle status page, and the pagination tests in service were not deterministic.
How has this been tested? (if applicable)
Run
USE_PANAMAX=disable make shuttle-deployer, then run the test command from the gateway readme: