feat: add a project_id to gateway #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: refactor projects primary key to project_id * refactor: better comments * feat: remaining project state changes
chesedo
force-pushed
the
feature/eng-706-add-a-project_id-to-gateway
branch
from
051b5ec
to
ecfdf2f
Compare
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* Feat/refactor gateway state (shuttle-hq#1042) - ULID only * feat: refactor projects primary key to project_id * refactor: better comments * feat: remaining project state changes * refactor: update queries --------- Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This adds a ULID for project IDs to gateway. This will be needed for the new resource recorder.
It also replaces the need for a
created_atfield since the ULID has a timestamp in it.Most of gateway still uses the project name (and not this new id) everywhere. I think this is fine for now as the deployer update will take care to switch over to the IDs.
How has this been tested? (if applicable)
By running all the tests locally