fix(cargo-shuttle): break deploy logs when StartResponse is received #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
feature/eng-1203-cargo-shuttle-should-stop-the-deployment-logs-stream-after
branch
from
548a8e7
to
a0ad263
Compare
...StartResponse is received
iulianbarbu
force-pushed
the
feature/eng-1203-cargo-shuttle-should-stop-the-deployment-logs-stream-after
branch
from
a0ad263
to
3b804c5
Compare
...good messages vec.
jonaro00
reviewed
Sep 7, 2023
|
Closing this since it was already covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Receiving
StartResponsefor acargo shuttle deploymeans the deployment logs ended and we can stop the deployment logs stream.How has this been tested? (if applicable)
By locally deploying a project on a local deployer.