Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: separate ci and unstable jobs, better caching #1273

Merged
merged 9 commits into from Oct 2, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Sep 25, 2023

Description of change

image

  • unstable is no longer part of the ci job
    • makes approving/cancelling/rerunning unstable job much cleaner
  • less filters for jobs that already depend on filters
  • faster

How has this been tested? (if applicable)

Works with and without the filter commented

@jonaro00 jonaro00 changed the title ci: better separation of jobs ci: separate ci and unstable jobs Sep 25, 2023
@jonaro00 jonaro00 changed the title ci: separate ci and unstable jobs ci: separate ci and unstable jobs, better caching Oct 1, 2023
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one question.

.circleci/config.yml Show resolved Hide resolved
@jonaro00 jonaro00 merged commit 854df3f into shuttle-hq:main Oct 2, 2023
33 checks passed
@jonaro00 jonaro00 deleted the ci/separate-jobs branch October 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants