Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): added billing backend support #1289

Merged
merged 20 commits into from Oct 5, 2023
Merged

feat(auth): added billing backend support #1289

merged 20 commits into from Oct 5, 2023

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Oct 2, 2023 •
edited

Description of change

Added backend billing support.

How has this been tested? (if applicable)

Integration tests were added.

TODO:

  • add integration tests for a trial subscription?
  • simplify integration test mocking (checkout sessions and subscriptions objects can be parameterised and changed based on the fields of interest).

@iulianbarbu iulianbarbu changed the title Feat/billing backend support feat(auth): added billing backend support Oct 2, 2023
oddgrd
oddgrd reviewed Oct 2, 2023
View reviewed changes
auth/src/lib.rs Outdated Show resolved Hide resolved
@iulianbarbu iulianbarbu force-pushed the feat/billing_backend_support branch 3 times, most recently from af77509 to d8e41cb Compare October 4, 2023 10:05
oddgrd
oddgrd approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two nits

auth/src/user.rs Outdated Show resolved Hide resolved
DEVELOPING.md Outdated Show resolved Hide resolved
oddgrd
oddgrd reviewed Oct 4, 2023
View reviewed changes
auth/src/user.rs Outdated Show resolved Hide resolved
oddgrd
oddgrd reviewed Oct 4, 2023
View reviewed changes
auth/src/user.rs Outdated Show resolved Hide resolved
@iulianbarbu
misc(auth): add async-stripe dep
e41ceb8
@iulianbarbu
feat(auth): added update tier handler
b4a97e7 
The update tier accounts for changing the tier to Pro, requiring a
payload with a completed checkout session in case of upgrading to Pro.
@iulianbarbu
feat(auth): check subscription validity when getting user
29aca68
@iulianbarbu
feat(common): user Response with subscription id if any
c7b1ad9
@iulianbarbu
test(auth): added integration tests for pro upgrade/downgrade
8624fb6
@iulianbarbu
auth: added DEVELOPING notes and STRIPE_SECRET_KEY in Makefile
a097e35
@iulianbarbu
fix(auth): CI for auth fails because of memory preassure
09d20e3
@iulianbarbu
auth: address O review comment on builder
eaf4302
@iulianbarbu
circleci: added STRIPE_SECRET_KEY deploy images param
bd681b6
@iulianbarbu
auth: change how we decode
47fb2d0
@iulianbarbu
auth: remove debug event
42a664b
@iulianbarbu
DEVELOPING: adjust testing Pro tier notes
b83157a
@iulianbarbu
auth: fix field name
75365a0
@iulianbarbu
auth: async-stripe relies on rustls and installed certs
1e42966
@iulianbarbu
auth: added executable rights to prepare.sh
199308f
@iulianbarbu
auth: update first the mirrors
e5afded
@iulianbarbu
auth: add non-interactive flag
d38894d
@iulianbarbu
auth: fix prepare_args passing
adef6d5
@iulianbarbu
auth: bump 0.28.1 && add explicit package version
4d81aff
@iulianbarbu
common: bump to 0.28.1
b878aac
@iulianbarbu iulianbarbu mentioned this pull request Oct 5, 2023
Closed
@iulianbarbu iulianbarbu merged commit b37b03f into shuttle-hq:main Oct 5, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iulianbarbu @oddgrd