Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo-shuttle panic on the login command #1302

Merged
merged 2 commits into from Oct 5, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 5, 2023

Description of change

Fixes #1300
Thought the unwrap was safe but this is safer and more correct :)
Also bumping to .1 for release

How has this been tested? (if applicable)

Tested locally, both forms of login command, and init command.

@oddgrd
Copy link
Contributor

oddgrd commented Oct 5, 2023

Hmm, I only see changes to feedback and complete, how does this fix login? NVM, I didn't read it correctly. 😅

@oddgrd oddgrd merged commit bdbf92f into shuttle-hq:main Oct 5, 2023
33 checks passed
@jonaro00 jonaro00 deleted the fix/login-panic branch October 5, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cargo-shuttle login panics
2 participants