refactor: fix ProjectName validation, custom Path extractor for parsing it #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the entire workspace is compiled together, like in CI clippy check, logger enables the sqlx/postgres feature. When ProjectName in common is compiled, it is usually done with only the sqlx/sqlite feature. Enabling postgres from logger makes the sqlx derive macro break for some reason. This fixes it.
Might save some time by performing the constant time and light-weight checks before iterating over all characters or checking for profanities. Also remove double negations to make the boolean expression more readable.
oddgrd
approved these changes
Nov 2, 2023
jonaro00
force-pushed
the
project-name-extractor
branch
from
ee129b9
to
5d55f6e
Compare
jonaro00
changed the title
jonaro00
changed the title
chesedo
reviewed
Nov 3, 2023
jonaro00
force-pushed
the
project-name-extractor
branch
from
b9ac3be
to
7852e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Custom axum extractor that prints the parse error message for the custom deser.
Supersedes of #1236, Check only the last commits.
How has this been tested? (if applicable)
On normal API calls
On interaction in init (should this be red?)