Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): type conversion from str for a custom resource #1415

Conversation

iulianbarbu
Copy link
Contributor

Description of change

We're missing the Custom resource type conversion from str.

How has this been tested? (if applicable)

Reproduced when I deployed the custom-resource/pdo example.
TODO: test the project deployment again after the fix.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives me a feeling of déjà vu, I thought we fixed this a while back 😅

@iulianbarbu
Copy link
Contributor Author

I was surprised to see the error too. Not sure what we've fixed the last time, or if we introduced a regression in the meantime. I haven't digged into it, but it might not be worth doing it.

@iulianbarbu iulianbarbu merged commit da6b887 into shuttle-hq:main Nov 23, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants