revert: rate limit based on peer address #1351 #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
commented
Nov 27, 2023
Comment on lines
+666
to
+667
| error!(error = %error, "failed to retrieve logs for deployment"); | ||
| Err(anyhow!("failed to retrieve logs for deployment").into()) |
There was a problem hiding this comment.
If this were to be reverted, it would be reverted to return a 404, but that would be incorrect, so I left this in.
|
Note: I did not revert this change: https://github.com/shuttle-hq/shuttle/pull/1351/files#diff-5d10b574e97438514650fd6f44664299baf20536aab73554ca2754906d2a72d4L382-R447, since it would ease implementing rate limiting based on number of requests in the future if the log batches are smaller. |
|
Can we also not revert the log error handling in c-s? to remain along with: #1429 |
Thanks, that's a good idea! |
jonaro00
approved these changes
Nov 28, 2023
jonaro00
deleted the
feature/eng-1945-rate-limiting-interprets-all-peers-as-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Revert #1351. While testing locally, the rate limiting layer worked as expected. However, when deployed in swarm mode, Docker puts a load balancer in front of the services in the user network. Therefore, it appears to the rate limiter that all logger requests are coming from the same peer address.
How has this been tested? (if applicable)
Tested that logging works as expected locally (get_logs and get_logs --follow).