New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(installer): add windows installer script #1503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will test on my windows machine later
Tried it on a machine that has tar but not rust:
(added the bin folder manually, then)
(opened and ran it again)
|
Should the script create the
|
After resolving (3), this is probably ready to be merged. |
Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks so much @supleed2!
* feat(installer): add windows installer script * fix: Update command to use pipe * Make confirm prompt case-insensitive * Added -Force flag to Move-Item * Replace exit with return and wrap in function
Description of change
Adds Powershell script, following steps as in bash install script, closes #1496.
Install command added to readme will work once shuttle-hq/www#220 is merged.
How has this been tested? (if applicable)
Tested locally on multiple machines, including commenting out codepaths to check both sides of branches. The section for downloading a binary may need to be updated in the future if CI is updated to produce aarch64 windows binaries.