feat: write a wrapper for the provisioner to call gw and r-r clients #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
reviewed
Jan 25, 2024
…-a-wrapper-for-the-provisioner-to-call-gwr-r-clients
Having this trait in `limits.rs` exposes too much to c-s and user services.
oddgrd
reviewed
Jan 26, 2024
jonaro00
reviewed
Jan 26, 2024
…-a-wrapper-for-the-provisioner-to-call-gwr-r-clients
The tests kept failing on the CI for what appears to be the tokio spawn of the server shutting down since it gave errors for the client not being able to connect.
I needed to move the internal `tracing` module to `trace` to prevent a clash with the `tracing` library.
chesedo
force-pushed
the
feature/engn-55-write-a-wrapper-for-the-provisioner-to-call-gwr-r-clients
branch
from
c4efc96
to
8989dfa
Compare
oddgrd
approved these changes
Jan 29, 2024
chesedo
commented
Jan 29, 2024
chesedo
deleted the
feature/engn-55-write-a-wrapper-for-the-provisioner-to-call-gwr-r-clients
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allows provisioner to check how many RDSs a user is already using before trying to provision a new one.
How has this been tested? (if applicable)
A whole lot of new tests