fix(deployer): check correct config field(s) in resource cache #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
fix-db-resource-cache-miss
branch
from
7b31a10
to
2ba6b90
Compare
jonaro00
approved these changes
Mar 12, 2024
jonaro00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For now, the resources config are not relevant for the provisioning, so caching based on them is not required.
Furthermore, the way the codegen creates the resource configs in the
loaderis based on the resources inputbuilder default implementation, which for databases depends on
DbInput, which is "{ 'local_uri': null, 'db_name': null }".Comparing this to the way we store the configs for any resource in resource-recorder:
serde_json::Value::Null, thenwhen checking the cache we'll always get a miss given we check for configs equality.
Existing projects must upgrade their deployers to be able to provision RDSs and do subsequent deployments.
How has this been tested? (if applicable)
On staging, provision database is not called anymore on subsequent deployments once the db was provisioned.