feat(gateway): compare permission checks to permit #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
permit-gateway-sync
branch
from
bbd06de
to
5cf5c53
Compare
jonaro00
force-pushed
the
permit-permission-checks
branch
from
f1fa172
to
e3c9bcb
Compare
jonaro00
force-pushed
the
permit-permission-checks
branch
from
03ecb3a
to
6c66c7b
Compare
jonaro00
force-pushed
the
permit-permission-checks
branch
from
6c66c7b
to
ef3f90b
Compare
chesedo
reviewed
Apr 2, 2024
| @@ -32,18 +32,15 @@ where | |||
| { | |||
| type Rejection = Error; | |||
|
|
|||
| async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> { | |||
| async fn from_request_parts(parts: &mut Parts, _state: &S) -> Result<Self, Self::Rejection> { | |||
| let claim = parts.extensions.get::<Claim>().ok_or(ErrorKind::Internal)?; | |||
| let user_id = claim.sub.clone(); | |||
There was a problem hiding this comment.
Does it make sense to still have a User struct? We can just implement FromRequestParts for the claim right?
There was a problem hiding this comment.
only traits defined in the current crate can be implemented for a type parameter
Claim can technically be moved to backends (it seems), but I'd skip it for now.
jonaro00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Compare project access to Permit project access.
Use Permit for project list.
Remove project list pagination.
How has this been tested? (if applicable)
Staging