Add log streaming in beta platform #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Apr 17, 2024
jonaro00
reviewed
Apr 17, 2024
| @@ -832,6 +837,38 @@ impl Shuttle { | |||
| Ok(CommandOutcome::Ok) | |||
| } | |||
|
|
|||
| async fn logs_beta(&self, args: LogsArgs) -> Result<CommandOutcome> { | |||
There was a problem hiding this comment.
will there be a non-streaming option?
There was a problem hiding this comment.
Yes, and probably sooner rather than later since I've just discovered the cost of a Kinesis Stream 🥲
| if args.raw { | ||
| println!("{}", log.line); | ||
| } else { | ||
| println!("[{}] ({}) {}", log.timestamp, log.source, log.line); |
There was a problem hiding this comment.
I don't think we should use Display there. It's only useful in the context of printing to the console.
iulianbarbu
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I've pushed against having v1/v2, we'll refactor later, but that's the cleanest way I've found.