feat: add new deployment metadata to table #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
reviewed
Jun 9, 2023
iulianbarbu
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Sorry for the late review @Fuzzicles ! We're a bit low on review resources because we have some competing priorities coming from a bigger release and an upcoming offsite.
Other than this, the PR is very close.
iulianbarbu
reviewed
Jun 21, 2023
|
@Fuzzicles Looking good on my side. There could be cases where user has a very long branch name etc, but overall this is good. The upcoming ULID's will also make this prettier :D (For @iulianbarbu) Here are some views of the table at different terminal widths: |
iulianbarbu
approved these changes
Jun 23, 2023
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* feat: add new deployment metadata to table * refactor: review comment --------- Co-authored-by: Grant Lorello <grant.lorello@msn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I added the new
git_*fields to the table output ofcargo shuttle deployment list.Closes #981
How has this been tested? (if applicable)
I created a new project via the rocket example and made local changes to check that the
git_dirtyfield rendered correctly, and that truncating the commit ID and message worked as intended. I also created some deployments with a version prior to the addition of the new metadata to make sure theOptionvalues correctly displayedNo Datain the table.