New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scaling] feat: builder service #999
Merged
chesedo
merged 10 commits into
shuttle-hq:feat/shuttle-runtime-scaling
from
chesedo:feature/eng-641-write-builder-service
Jun 19, 2023
Merged
[scaling] feat: builder service #999
chesedo
merged 10 commits into
shuttle-hq:feat/shuttle-runtime-scaling
from
chesedo:feature/eng-641-write-builder-service
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this standardized design for services makes reviewing a lot easier! 🥳 LGTM! Just one question about the builder.
chesedo
merged commit Jun 19, 2023
59d3414
into
shuttle-hq:feat/shuttle-runtime-scaling
19 of 20 checks passed
chesedo
added a commit
to chesedo/shuttle
that referenced
this pull request
Jul 12, 2023
* feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint
chesedo
added a commit
that referenced
this pull request
Jul 17, 2023
* [scaling] feat: create a resource service (#906) * feat: skeleton resource-recorder * test: adding resources * feat: add resources * feat: get resources * refactor: constant service id * feat: keep track of inactive resources * test: resource can be updated * feat: get by project id * feat: deleting resources * refactor: sortable ids * refactor: clippy suggestion * feat: column indices * feat: record resource route * feat: get resources route * feat: delete resource route * tests: integration tests * feat: scope routes * refactor: verify claim * refactor: remove resource management from deployer-alpha * tmp: native-tls * Apply suggestions from code review Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com> * refactor: make fields private * refactor: fix file name * tests: redundant unit tests * refactor: add last_updated field * refactor: error on ID errors * refactor: comments --------- Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com> * fix: compile errors after merge, update cargo.lock * [scaling] feat: builder service (#999) - only test refactor * feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint * refactor: cherry-pick misses * ci: add resource-recorder * refactor: add Turso type --------- Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com>
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* [scaling] feat: create a resource service (shuttle-hq#906) * feat: skeleton resource-recorder * test: adding resources * feat: add resources * feat: get resources * refactor: constant service id * feat: keep track of inactive resources * test: resource can be updated * feat: get by project id * feat: deleting resources * refactor: sortable ids * refactor: clippy suggestion * feat: column indices * feat: record resource route * feat: get resources route * feat: delete resource route * tests: integration tests * feat: scope routes * refactor: verify claim * refactor: remove resource management from deployer-alpha * tmp: native-tls * Apply suggestions from code review Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com> * refactor: make fields private * refactor: fix file name * tests: redundant unit tests * refactor: add last_updated field * refactor: error on ID errors * refactor: comments --------- Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com> * fix: compile errors after merge, update cargo.lock * [scaling] feat: builder service (shuttle-hq#999) - only test refactor * feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint * refactor: cherry-pick misses * ci: add resource-recorder * refactor: add Turso type --------- Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com> Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com>
chesedo
added a commit
that referenced
this pull request
Sep 14, 2023
* feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint
chesedo
added a commit
that referenced
this pull request
Sep 14, 2023
* feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint
chesedo
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint
chesedo
added a commit
that referenced
this pull request
Sep 15, 2023
* feat: builder init * feat: build route * feat: builder service * feat: binary and docker image * refactor: clippy suggestions * refactor: move test helpers to common crate * refactor: trim deployer-alpha * refactor: get name from nbuild * refactor: .crate to .tar.gz * refactor: Cmd to Entrypoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
A builder service for our new scaling project
How has this been tested? (if applicable)
With new tests that were added in the code