Attribute related changes #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
+ Coverage 88.20% 88.22% +0.02%
==========================================
Files 860 862 +2
Lines 38651 38820 +169
Branches 5000 5021 +21
==========================================
+ Hits 34092 34250 +158
- Misses 3421 3427 +6
- Partials 1138 1143 +5
Continue to review full report at Codecov.
|
n1ro0
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
3 times, most recently
from
0d8848a
to
80292f1
Compare
chessbr
suggested changes
Apr 20, 2021
There was a problem hiding this comment.
1. Add the max_choices field in the base form part
You can show/hide it according to the user selection. Add some JS to the template to do it.
2. Use a different icon (maybe fa-list-ol) for the Choice Options and rename it to Choices
3. Add some buttons to add and remove forms this way, better user experience.
chessbr
suggested changes
Apr 20, 2021
n1ro0
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
6 times, most recently
from
39fe456
to
8594221
Compare
- Admin: New type of attribute: CHOICES - Admin: Selection of multiple choices from attribute for product - Front: Product filter by attribute choices
chessbr
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
from
8594221
to
fcd9838
Compare
chessbr
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
from
fcd9838
to
540f16a
Compare
chessbr
reviewed
Apr 29, 2021
shuup/utils/fields.py
Outdated
| value = super().clean(value) | ||
| if self.min_limit is not None and len(value) < self.min_limit: | ||
| ending = "" if self.min_limit % 10 == 1 else "s" | ||
| raise forms.ValidationError(f"You can't select less than {self.min_limit} item{ending}.") |
There was a problem hiding this comment.
maybe use pluralization https://docs.djangoproject.com/en/3.2/topics/i18n/translation/#pluralization
n1ro0
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
from
3211e9f
to
8cb3ceb
Compare
n1ro0
force-pushed
the
add-attribute-options-and-attribute-filtering
branch
from
8cb3ceb
to
5f91d63
Compare
chessbr
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added