Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selected value for XThemeModelChoiceWidget (SHUUP-2748) #532

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Fix selected value for XThemeModelChoiceWidget (SHUUP-2748) #532

merged 1 commit into from
Jun 9, 2016

Conversation

gurch101
Copy link
Contributor

@gurch101 gurch101 commented Jun 9, 2016

Ensure selected value comparison is done using the same datatypes.

Refs SHUUP-2748

@gurch101
Fix selected value for XThemeModelChoiceWidget
cf91c16 
Ensure selected value comparison is done using the same datatypes.

Refs SHUUP-2748
@anders-jenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1971/
Test PASSed.

@coveralls
Copy link

coveralls commented Jun 9, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.232% when pulling cf91c16 on gurch101:fix-xtheme-field-selectedval into 5a012af on shuup:master.

@tulimaki tulimaki merged commit eb9a192 into shuup:master Jun 9, 2016
@gurch101 gurch101 deleted the fix-xtheme-field-selectedval branch July 1, 2016 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gurch101 @anders-jenkins @coveralls @tulimaki