-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-level permissions and admin management (SHUUP-2703) #549
Conversation
Refer to this link for build results (access rights to CI server needed): |
|
||
def save(self): | ||
obj = super(PermissionGroupForm, self).save() | ||
obj.permissions.clear() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is unnecessary
2a8a28a
to
55069f1
Compare
Refer to this link for build results (access rights to CI server needed): |
1f7a4cc
to
fdf8af3
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@@ -74,6 +74,7 @@ Localization | |||
Admin | |||
~~~~~ | |||
|
|||
- Define permissions for all admin modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are actually defining module level permissions for all admin modules
?
Add support for module-level permissions. Modules define their own permissions by overriding `get_required_permissions`, returning a list of permission strings. If a user doesn't have the required permissions, they will not see the module's menu entries. Refs SHUUP-2703, SHUUP-2817
fdf8af3
to
f900bde
Compare
Refer to this link for build results (access rights to CI server needed): |
Add Permission Groups module for managing module-level access for staff users. Refs SHUUP-2703, SHUUP-2820
Enable adding permission groups from `Users` admin permissions edit view. Refs SHUUP-2703, SHUUP-2819
Define permissions for all admin modules by implementing `get_required_permissions` and defining url-level permissions. Refs SHUUP-2703, 2818
f900bde
to
58d39e5
Compare
Refer to this link for build results (access rights to CI server needed): |
retest this please |
1 similar comment
retest this please |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refs SHUUP-2703, SHUUP-2817, SHUUP-2819, SHUUP-2820, SHUUP-2818