Core: Make contact language required information (SH-439, SH-428) #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulimaki
reviewed
Nov 7, 2016
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('shuup', '0010_update_managers'), |
There was a problem hiding this comment.
This should be dependent on 11 and this migration 12.
tulimaki
reviewed
Nov 7, 2016
| elif self.customer: | ||
| lang = self.customer.language | ||
|
|
||
| if not is_existing_language(lang): |
There was a problem hiding this comment.
Is this if really needed it seems that after the customer doesn't exist the language is settings.LANGUAGE_CODE
There was a problem hiding this comment.
I was thinking this too, but source.language can be set to something strange thus must be validated. imo.
|
LGTM after these few issues. Also changelog could be added since there is new things in this PR. |
We are relying on Babel when it comes to translations. It was, however, possible to use languages that were extinct long time ago. These helpers will help you identify valid languages for Shuup coding environment. Refs SH-439
Also fix issue with extinct languages by using the newly introduced helpers in Shuup. Refs SH-439
Refs SH-439
Source language was never transferred back to Order which caused language being lost when Source was used as a base for Order. Refs SH-439, SH-428
Old language was pretty much unused and the value was only applied if the programmer knew that it should be set. Change the functionality so that if the `OrderSource` has no language set, the customers language will be used as a language for `OrderSource` too. `OrderSource` must have a language set, so if no valid languages are found, source will use `settings.LANGUAGE_CODE`. Also add tests to show that this change makes notification emails to be send in proper language. Refs SH-428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helpers to identify existing languages
We are relying on Babel when it comes to translations. It was,
however, possible to use languages that were extinct long time ago.
These helpers will help you identify valid languages for Shuup coding
environment.
Add
LanguageFormFieldAlso fix issue with extinct languages by using the
newly introduced helpers in Shuup.
** Core: Start actually using
Contact.language**Core: Fix bug with order_source.language
Source language was never transferred back to Order which caused language being lost when Source was used as a base for Order.
Core: Make
OrderSource.languageusableOld language was pretty much unused and the value was
only applied if the programmer knew that it should be set.
Change the functionality so that if the
OrderSourcehas no language set, the customers
language will be used as a language for
OrderSourcetoo.OrderSourcemust have a language set, so if no validlanguages are found, source will use
settings.LANGUAGE_CODE.Also add tests to show that this change makes notification emails to
be send in proper language.
Refs SH-439, SH-428