Lps 58449 Refactor scheduler related classes

[tinatian]

Hi Shuyang,

With these changes, a NumberFormatException would come up while starting portal, it is caused by an old bug(see https://issues.liferay.com/browse/LPS-58479), will send pull request to Micheal Han who made those changes before.

Tina.

[liferay-continuous-integration]

Some tests FAILED!

Build Time: 1 hour 30 minutes 14 seconds

Job Results:

17 Jobs Passed.
1 Job Failed.

See the following links for more information.

• test-portal-acceptance-pullrequest(master)

  Completed with the status of FAILURE.

• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/portal-smoke

• test-portal-acceptance-pullrequest-batch(master)/integration-db2

• test-portal-acceptance-pullrequest-batch(master)/integration-mysql

• test-portal-acceptance-pullrequest-batch(master)/integration-oracle

• test-portal-acceptance-pullrequest-batch(master)/integration-postgresql

• test-portal-acceptance-pullrequest-batch(master)/integration-sybase

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase

  Job Results:

  15 Tests Passed.
  1 Test Failed.

  • test-portal-acceptance-pullrequest-batch(master) ?? 3,!master #8959

    m/liferay/portal/security/pacl/Reflection.java:59: warning: Reflection is internal proprietary API and may be removed in a future release
         [exec] 			return sun.reflect.Reflection.getCallerClass(depth + 2);
         [exec] 			                  ^
         [exec] Note: /opt/dev/projects/github/liferay-portal/modules/core/portal-security-pacl/src/com/liferay/portal/security/pacl/Reflection.java uses or overrides a deprecated API.
         [exec] Note: Recompile with -Xlint:deprecation for details.
         [exec] 2 warnings
         [exec] :core:registry-api:buildCSS UP-TO-DATE
         [exec] :core:registry-api:copyLibs
         [exec] :core:portal-equinox-log-bridge:autoUpdateXml SKIPPED
         [exec] :core:portal-equinox-log-bridge:deploy
         [exec] :frontend:frontend-editors-web:buildAlloyEditor
         [exec] :frontend:frontend-common-css:autoUpdateXml SKIPPED
         [exec] :frontend:frontend-common-css:deploy
         [exec] :frontend:frontend-js-polyfill-babel-web:downloadNode
         [exec] :core:portal-security-pacl:buildCSS UP-TO-DATE
         [exec] :core:portal-security-pacl:copyLibs
         [exec] :core:portal-log4j-extender:autoUpdateXml SKIPPED
         [exec] :core:portal-log4j-extender:deploy
         [exec] :frontend:frontend-taglib:buildCSS UP-TO-DATE
         [exec] :frontend:frontend-taglib:compileJava
         [exec] :core:osgi-service-tracker-map:buildCSS UP-TO-DATE
         [exec] :core:osgi-service-tracker-map:copyLibs
         [exec] :frontend:frontend-css-web:compileJava
         [exec] :core:registry-api:copyLibs UP-TO-DATE
         [exec] :core:registry-api:processResources UP-TO-DATE
         [exec] :core:registry-api:classes
         [exec] :core:registry-api:jar UP-TO-DATE
         [exec] :core:registry-api:autoUpdateXml SKIPPED
         [exec] :core:jaxws-osgi-bridge:compileJava
         [exec] :core:osgi-service-tracker-map:processResources UP-TO-DATE
         [exec] :core:osgi-service-tracker-map:classes
         [exec] 
         [exec] gzip: stdin: unexpected end of file
         [exec] tar: Unexpected EOF in archive
         [exec] tar: Unexpected EOF in archive
         [exec] tar: Error is not recoverable: exiting now
         [exec] :core:osgi-service-tracker-map:jar
         [exec] :frontend:frontend-js-polyfill-babel-web:downloadNode FAILED
         [exec] Note: Some input files use unchecked or unsafe operations.
         [exec] Note: Recompile with -Xlint:unchecked for details.
         [exec] :core:osgi-service-tracker-map:autoUpdateXml SKIPPED
         [exec] 
         [exec] BUILD FAILED
         [exec] 
         [exec] Total time: 4 mins 58.154 secs
         [exec] 
       

• test-portal-acceptance-pullrequest-batch(master)/modules-unit

• test-portal-acceptance-pullrequest-batch(master)/plugins

• test-portal-acceptance-pullrequest-batch(master)/portal-web

• test-portal-acceptance-pullrequest-batch(master)/service-builder

• test-portal-acceptance-pullrequest-batch(master)/tck

• test-portal-acceptance-pullrequest-batch(master)/unit

• test-portal-acceptance-pullrequest-source(master)

[tinatian]

ci:retest

[shuyangzhou]

It is ok, the build failure is not caused by you. I just did not have time to review it yet, will try to get on to it tomorrow.

[liferay-continuous-integration]

Some tests FAILED!

Build Time: 55 minutes 26 seconds

Job Results:

16 Jobs Passed.
2 Jobs Failed.

See the following links for more information.

• test-portal-acceptance-pullrequest(master)

  Completed with the status of FAILURE.

• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/portal-smoke

• test-portal-acceptance-pullrequest-batch(master)/integration-db2

• test-portal-acceptance-pullrequest-batch(master)/integration-mysql

• test-portal-acceptance-pullrequest-batch(master)/integration-oracle

• test-portal-acceptance-pullrequest-batch(master)/integration-postgresql

• test-portal-acceptance-pullrequest-batch(master)/integration-sybase

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2

  Job Results:

  3835 Tests Passed.
  2 Tests Failed.

  • LockLocalServiceTest.testMutualExcludeLockingParallel
  • PortalLogAssertorTest.testScanXmlLog

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql

  Job Results:

  15 Tests Passed.
  1 Test Failed.

  • test-portal-acceptance-pullrequest-batch(master) ?? 3,!master #9123

    delete-liferay-home:
       [delete] Deleting directory /opt/dev/projects/github/liferay-portal/osgi/state
       [script] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
       [script] Loading file:/opt/dev/projects/github/liferay-portal/portal-service/test-classes/unit/system-ext.properties
         [exec] psql: could not connect to server: No such file or directory
         [exec] 	Is the server running locally and accepting
         [exec] 	connections on Unix domain socket "/tmp/.s.PGSQL.5432"?
         [echo] The following error occurred while executing this line:
         [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:364: The following error occurred while executing this line:
         [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:386: The following error occurred while executing this line:
         [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5731: exec returned: 2

• test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase

• test-portal-acceptance-pullrequest-batch(master)/modules-unit

• test-portal-acceptance-pullrequest-batch(master)/plugins

• test-portal-acceptance-pullrequest-batch(master)/portal-web

• test-portal-acceptance-pullrequest-batch(master)/service-builder

• test-portal-acceptance-pullrequest-batch(master)/tck

• test-portal-acceptance-pullrequest-batch(master)/unit

• test-portal-acceptance-pullrequest-source(master)

[shuyangzhou]

I don't really like the TriggerContent design, that is technically the same as what we currently have with TriggerType, after all in the end you still have to instance of to test the actual TriggerContent type to behave differently.

I think we should create our own TriggerBuilder interface/impl, bridge it to Quartz's TriggerBuilder at impl level. At least this way we don't have to do instance of any more.

If you think otherwise, please resend, then we can talk about it.

[tinatian]

Em....I will think about your suggestion, will resend pull request about this.