Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-115509 #9169

Closed
wants to merge 2 commits into from
Closed

[TS] LPS-115509 #9169

wants to merge 2 commits into from

Conversation

ericyanLr
Copy link

https://issues.liferay.com/browse/LPS-115509

Hi @shuyangzhou ,

The goal of this PR is to address an issue, where:

  • a cache file is retrieved
  • clean-up is called
  • the retrieved cache file no longer exists (deleted during clean-up)
  • FileNotFoundException is thrown when we attempt to return a FileInputStream of the retrieved cache file (since it got deleted during clean-up)

Commit: Avoid NoSuchFileException when cache directory does not exist
If cacheDirPath does not exist, Files.walkFileTree throws a NoSuchFileException.

Note: the clean-up process also deletes the cache directory if it does not contain any files.

Please let me know if you have any questions.
Thanks!

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ericyanLr
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a328ded8dd3200e439bfe1eeec06aab56dfb9c11

Sender Branch:

Branch Name: LPS-115509
Branch GIT ID: c3c4f431e2e205eeabdb412ef1b1a12d2d439978

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@shuyangzhou
Copy link
Owner

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 47 out of 47 jobs passed in 1 hour 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ee8af6d3c052b2e98f267e2ca397582fa816f1a7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1048e471849c8076c4823cc7dd4b82abffdac7c4

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 47 out of 47 jobs PASSED
47 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#90179

@vicnate5
Copy link

Scheduled QA testing for this change, but it can be done after merge
https://issues.liferay.com/browse/LRQA-59502

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#5687
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:shuyangzhou#9169
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:test-1-7/test-portal-acceptance-pullrequest(master)/5687 - 2020-06-16[09:53:32]
Spira Jenkins Build:publish-spira-report#1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
4 participants
@ericyanLr @liferay-continuous-integration @shuyangzhou @vicnate5