[Freemarker loop size]LPS-124811 #9685

tinatian · 2020-12-17T17:59:45Z

No description provided.

…he selected target

… if applies. Database goalTarget keeps the same format

…nd static env

This order was on purpose. Originally we were taking the v= value as everything to the right including parameters which was wrong. With those tests we were ensuring this wouldn't happen again. This reverts commit d0cab88.

…ent scheduled Web Contents by getting their id_ as classPK instead of their resourcePrimKey

…o price

…se the user click on the fragment it prevents to play the video and behaves the same than any other fragment

…ntation This basically means that the server will render an empty placeholder and then components (if passed) will be hydrated client-side. Additionally, we introduce a temporary workaround to reduce cumulative layout shift. If a `__placeholder__` property is passed in the `context` object, the renderer will use that instead of an empty placeholder so tag implementors can choose to manually generate it temporarily.

This effectively removes server-side support for Soy rendering, meaning that there won't be an available template manager for soy templates in the server. This doesn't mean that compiled soy templates to JavaScript won't work which reamin as a viable path forward if a developer decides to use them

This markup is used server-side to provide initial markup as a fallback now that we're no longer rendering soy to limit layout cumulative shift when the component hydrates client-side This commit still leaves a slight shift because an empty toolbar has different height than one with content. This is a small adjustment to adress later either by agreeing on a fixed height or by rendering additional elements in the placeholder

…doesn't exist This is necessary because in some contexts the toolbar lacks an ide at this point. This can happen if no id or componentId is set and the toolbar is not linked to a search container

liferay-continuous-integration · 2020-12-17T17:59:49Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

tinatian · 2020-12-17T17:59:56Z

ci:test:relevant

tinatian · 2020-12-17T18:00:02Z

ci:test:sf

liferay-continuous-integration · 2020-12-17T18:05:15Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c273cecd70ab4ba75d05cf6c8d7b9f0058d7e2cc

Sender Branch:

Branch Name: LPS-124811-1
Branch GIT ID: 999a44ba8a84fe061c06d3f93ebf903cb6183e74

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-12-17T18:21:12Z

Jenkins Build:test-portal-source-format#5085
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:shuyangzhou#9685
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - tinatian > shuyangzhou - PR#9685 - 2020-12-17[10:00:20]
Spira Jenkins Build:publish-spira-report#11507

liferay-continuous-integration · 2020-12-17T21:03:26Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 24 jobs passed in 2 hours 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff0e5e147ea14773fc626b3a4024d041bfefb138

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 24 jobs PASSED

4 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

159 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #318245

FreeMarkerTemplateTest.testLoopSizeThreshold

java.lang.AssertionError: 
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at com.liferay.portal.template.freemarker.internal.FreeMarkerTemplateTest._testLoopSizeThreshold(FreeMarkerTemplateTest.java:411)
	at com.liferay.portal.template.freemarker.internal.FreeMarkerTemplateTest.testLoopSizeThreshold(FreeMarkerTemplateTest.java:131)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.Parent...

Failures in common with acceptance upstream results at ff0e5e1:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #314364

Please fix semantic versioning on tinatian/LPS-124811-1

     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.String,java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     <init>(java.lang.Throwable)
     [exec] 			+   return     void
     [exec] 		+   method     addSuppressed(java.lang.Throwable)
     [exec] 			+   access     final
     [exec] 			+   return     void
     [exec] 		+   method     clone()
     [exec] 			+   access     protected
     [exec] 			+   return     java.lang.Object
     [exec] 		+   method     equals(java.lang.Object)
     [exec] 			+   return     boolean
     [exec] 		+   method     fillInStackTrace()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     finalize()
     [exec] 			+   access     protected
     [exec] 			+   return     void
     [exec] 		+   method     getCause()
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     getLocalizedMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getMessage()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     getStackTrace()
     [exec] 			+   return     java.lang.StackTraceElement[]
     [exec] 		+   method     getSuppressed()
     [exec] 			+   access     final
     [exec] 			+   return     java.lang.Throwable[]
     [exec] 		+   method     hashCode()
     [exec] 			+   return     int
     [exec] 		+   method     initCause(java.lang.Throwable)
     [exec] 			+   return     java.lang.Throwable
     [exec] 		+   method     printStackTrace()
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintStream)
     [exec] 			+   return     void
     [exec] 		+   method     printStackTrace(java.io.PrintWriter)
     [exec] 			+   return     void
     [exec] 		+   method     setStackTrace(java.lang.StackTraceElement[])
     [exec] 			+   return     void
     [exec] 		+   method     toString()
     [exec] 			+   return     java.lang.String
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.18.0/471e51c2d8cc477362ba9dd7449b8c3974545660/com.liferay.portal.kernel-9.18.0.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
166 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=8,label_exp=!master #449561
  1. LocalFile.ContentPagesWithMapping#MapManualURLToImageFragment - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

159 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #318245

SampleSQLBuilderTest.testGenerateAndInsertSampleSQL

java.lang.Exception: Unable to process FreeMarker template 
	at com.liferay.portal.tools.sample.sql.builder.SampleSQLBuilder.compressSQL(SampleSQLBuilder.java:211)
	at com.liferay.portal.tools.sample.sql.builder.SampleSQLBuilder.<init>(SampleSQLBuilder.java:80)
	at com.liferay.portal.tools.sample.sql.builder.SampleSQLBuilderTest.testGenerateAndInsertSampleSQL(SampleSQLBuilderTest.java:95)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.Pare...

liferay-continuous-integration · 2020-12-17T21:45:00Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7293
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:shuyangzhou#9685
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - tinatian > shuyangzhou - PR#9685 - 2020-12-17[10:52:11]
Spira Jenkins Build:publish-spira-report#8873

dgarciasarai and others added 30 commits December 16, 2020 08:25

LPS-124870 Change Click Goal section and use a ClayInput to display t…

3bc69f0

…he selected target

LPS-124870 Build Lang

9bd30ea

LPS-124870 Manage state.selectedTarget without #. Display it manually…

1483d23

… if applies. Database goalTarget keeps the same format

LPS-124870 Fix tests

d9163b1

LPS-124870 Apply feedback

5349a29

LPS-124870 Rename tests

f92502c

LPS-124949 Ignore null results received from Sharepoint

ead4c08

LPS-105380 Add missing @OverRide

202c782

LPS-124964 Remove mismatching scriptlet marker

316b17f

COMMERCE-5273 data set display component now works in commerce fronte…

1d7fbc6

…nd static env

LPS-124868 Revert "LPS-124868 sort?"

592e960

This order was on purpose. Originally we were taking the v= value as everything to the right including parameters which was wrong. With those tests we were ensuring this wouldn't happen again. This reverts commit d0cab88.

LRQA-63760 Modify cases to add web content via JSONWS

549669f

LPS-124941 Adjust path to the new value set in LPS-115709

3e6a6f2

COMMERCE-5332 data set actions dropdown can now highlight items

597242e

LPS-123778 Override methods to observe the case of publishing subsequ…

77c9093

…ent scheduled Web Contents by getting their id_ as classPK instead of their resourcePrimKey

LPS-123778 Add override annotation

aeaec92

LPS-122603 Move questions configuration to message boards section

26754cb

LPS-77699 Update Translations

9c15aea

LPS-77699 Update Translations

7e3cd9e

COMMERCE-5239 if unit price is lower than promo then do not show prom…

bb576f7

…o price

LRQA-61739 Remove test from quarantine

4dd6c61

LPS-123925 Hide the roles tab for Guest account

629b2b2

LPS-124654 Adding a mask on top of video (only in edit mode) so in ca…

750e7a6

…se the user click on the fragment it prevents to play the video and behaves the same than any other fragment

COMMERCE-5335 data set display side panel fixed on rtl

8e83811

LPS-122956 Documents breaking changes

ded8020

LPS-122966 Deprecates remaining Soy supporting classes

6885d55

LPS-122956 Uses id instead of componentId and autogenerates it if it …

a9f2d99

…doesn't exist This is necessary because in some contexts the toolbar lacks an ide at this point. This can happen if no id or componentId is set and the toolbar is not linked to a search container

alee8888 and others added 13 commits December 16, 2020 19:32

LPS-122000 build-service-portal

bec162e

LRQA-63831 Update assertion

c6f3995

Baseline

ff0e5e1

LPS-124811 Initial checkin

3904157

LPS-124811 Patch Freemarker to add limitation to loop size

c4c69e2

LPS-124811 Update usages

644bc32

LPS-124811 build-lib-versions

373fa46

LPS-124811 Fix version manually

802800e

LPS-124811 Add support to config loop size threshold

bf3eb91

LPS-124811 BuildLang

a6cdae6

LPS-124811 Add unit test

cbcb6cb

LPS-124811 FAKE GRADLE CACHE

789986b

LPS-124811 Enable loop size checking on ci

999a44b

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 17, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 17, 2020

tinatian closed this Dec 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Freemarker loop size]LPS-124811 #9685

[Freemarker loop size]LPS-124811 #9685

tinatian commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

tinatian commented Dec 17, 2020

tinatian commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 17, 2020

[Freemarker loop size]LPS-124811 #9685

[Freemarker loop size]LPS-124811 #9685

Conversation

tinatian commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

tinatian commented Dec 17, 2020

tinatian commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 17, 2020

liferay-continuous-integration commented Dec 17, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 24 jobs passed in 2 hours 8 minutes

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 17, 2020