Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-127840 | Sitemap does not contain page names #9815

Closed
wants to merge 1 commit into from
Closed

[TS] LPS-127840 | Sitemap does not contain page names #9815

wants to merge 1 commit into from

Conversation

bakayattila
Copy link

Hi @shuyangzhou,

Could you please review this pull request?
https://issues.liferay.com/browse/LPS-127840

Thank you and best regards,
Attila

@bakayattila
LPS-127840 Only avoid groupfrendlyURL collision when it is necessary …
9b35192 
…in other cases it's enough to check for the content of the layoutFridnelyURL.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@bakayattila
Copy link
Author

ci:test:sf

@bakayattila
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9837c4d81f2de200ad2bcd7acc83578fb25e975c

Sender Branch:

Branch Name: LPS-127840
Branch GIT ID: 9b3519265cf6d3773e42dddaa314cb845e275f3e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5318
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:shuyangzhou#9815
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - bakayattila > shuyangzhou - PR#9815 - 2021-03-01[07:26:12]
Spira Jenkins Build:publish-spira-report#13886

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 21 jobs passed in 1 hour 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9837c4d81f2de200ad2bcd7acc83578fb25e975c

Upstream Comparison:

Branch GIT ID: 9837c4d81f2de200ad2bcd7acc83578fb25e975c
Jenkins Build URL: Acceptance Upstream DXP (master) #1589

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 21 jobs PASSED
21 Successful Jobs:
For more details click here.

@shuyangzhou
Copy link
Owner

@bakayattila on your pull testing the steps from the ticket, still not getting the expected result. Can you check again?
If it does work for you, please have @vicnate5 do a double check, thanks!

@shuyangzhou shuyangzhou closed this Mar 1, 2021
@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7649
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:shuyangzhou#9815
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - bakayattila > shuyangzhou - PR#9815 - 2021-03-01[07:26:43]
Spira Jenkins Build:publish-spira-report#16630

@bakayattila bakayattila mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@bakayattila @liferay-continuous-integration @shuyangzhou