Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of coordinates is not Culture independent #34

Closed
alex-piccione opened this issue Oct 14, 2017 · 0 comments
Closed

Parsing of coordinates is not Culture independent #34

alex-piccione opened this issue Oct 14, 2017 · 0 comments

Comments

@alex-piccione
Copy link

Running the unit tests on a PC with .Net in Italian ("it-IT" ) it does not pass.

Coordinate.cs TryParse() assumes the current Thread culture use dot as decimal separator.

method should use the double.Parse() and double.TryParse() overrides with NumberStyles and IFormatProvider parameters as I seen in other classes.

Example:
var deg1 = double.Parse(match.Groups["Deg1"].Value);
should be:
var deg1 = double.Parse(match.Groups["Deg1"].Value, CultureInfo.InvariantCulture);

double.TryParse(match.Groups["Min1"].Value, out temp)
should be:
double.TryParse(match.Groups["Min1"].Value, NumberStyles.None, CultureInfo.InvariantCulture, out temp)

I'm not sure NumberStyles.None is the best choice, but it works.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant