Extract parameter type translations #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibelius
reviewed
Mar 25, 2019
| JSXAttribute(path) { | ||
| const { node } = path; | ||
|
|
||
| if (hasStringLiteralJSXAttribute(path) && !isSvgElementAttribute(path)) { | ||
| addPhrase(node.value.value); | ||
| } | ||
| }, | ||
| JSXElement(path) { | ||
| const { node } = path; |
There was a problem hiding this comment.
better extract this logic to a function to make it clear
sibelius
reviewed
Mar 25, 2019
src/BabelPluginI18n.ts
Outdated
| textWithoutArgs += element.value; | ||
| } | ||
| if (element.type === 'JSXExpressionContainer') { | ||
| textWithArgs += `{arg${argIndex}}`; |
There was a problem hiding this comment.
we can try to improve naming of args
sibelius
reviewed
Mar 25, 2019
| const jsxContentNodes = n.value.children; | ||
| let text = ''; | ||
| let translateArgs = []; | ||
| let newChildren = []; |
There was a problem hiding this comment.
better move to a separate function
|
there are some tests failing Test Suites: 3 failed, 3 passed, 6 total we should setup CI for this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add resources extraction into same PR and improve overall quality, but see if you like the overall approach