Improve special key handling #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
property setter and getter are unnecessary as they add no logic.
to improve readability move the case to handle a non-callable attribute first as all the other code is only relevant for the callable case.
Versions before Qemu 2.12 (from ~2016) had a bug in handling keys requiring modifiers, e.g. Shift for upper-case letters: While the original VNC protocol was designed for remoting X11 applications, where high-level KeySyms are used (for example "Upper-case 'A'), Qemu (and other hardware virtualization tools) are required to translate that back into low-level KeyCode events: 1. Left-Shift down 2. 'A' down 3. 'A' up 4. Left-Shift up With the default `force_caps = False` this is fully done by Qemu, where version 2.8 shows the following bug: After sending a capital "A" even the next lower-case "a" is still received as an upper-case "A". This continues until the next upper-case letter is sent. With `force_capse = True` `vncdotool` does part of that translation and adds KeySyms for Shift-Down and Shift-Up itself, but reversed 3. and 4: 3. Left-Shift up 4. 'a' up Again this triggers a Qemu bug as now there is a discrepancy: 2. downs an *upper*-case "A" while 4. releases a *lower*-case "a". For `vndotool` is is irrelevant, but graphical VNC clients were affected. To not confuse Qemu release the keys in reverse order. Switch to logging the actual KeySyms sent to the VNC server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least (old) version of Qemu (2.6 from ~2016) have a problem when key-sequences are releases in the same order they are pressed. Reverse the order the the key pressed last is released first.
Also two minore code cleanups.