Bugfix/change config for relational database ds #234
Conversation
@bboure yes. I tested this behavior within my environment. It only works if you provide full ARN for a cluster. |
| @@ -104,6 +104,31 @@ class ServerlessAppsyncPlugin { | |||
| return { "Fn::GetAtt": [lambdaLogicalId, "Arn"] }; | |||
| } | |||
|
|
|||
| getDbClusterArn(config) { | |||
| if (config && config.dbClusterIdentifier) { | |||
| return this.generateDbClusterArn(config.dbClusterIdentifier, config.region); | |||
There was a problem hiding this comment.
@roznalex Could we maybe implement it so that:
- if an arn is given, use it
- if an "identifier" is given, generate the Arn from it
I would also keep an eye on Cloudformation's doc. I wouldn't be surprised if they'd "fix it" or add a new key dbClusterArn
There was a problem hiding this comment.
@bboure sure. So should we add support for two options: dbClusterIdentifier and dbClusterArn?
There was a problem hiding this comment.
No, I would wait and see what AWS does.
On second thought, let's leave it as it is and keep it "in sync" with cloudformations
There was a problem hiding this comment.
@roznalex ok, so in fact that means that dbClusterIdentifier should receive an arn, and we could forget about generating it
What do you think?
There was a problem hiding this comment.
@bboure I'm not sure that it is the right decision, because a user needs to build this ARN by himself. According to documentation Ref function returns a resource name, not ARN.
There was a problem hiding this comment.
There is the Fn::GetAtt function, but now I see that it does not return the Arn (not sure).
Let's keep it as it is. It would be good to maybe write a post on AWS forum and ask for more info on this.
|
@bboure I can follow up on this internally in AWS. Will sync up with you offline. |
Hi @bboure. Are there any updates? Could we merge this PR already? |
|
Sorry for late response @roznalex |
Hi, @bboure. Even AWS documentation may be wrong :)
There is a fix for the issue. I have added an automatic "dbClusterArn" generation. Now it should work correctly.