Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opensearch datasource #465

Merged
merged 9 commits into from
Mar 30, 2022
Merged

Conversation

nvanlo
Copy link
Contributor

@nvanlo nvanlo commented Jan 20, 2022

No description provided.

@nvanlo
Copy link
Contributor Author

nvanlo commented Jan 20, 2022

This pull request adds the OPEN SEARCH datasource as an alternative to the deprecated ELASTIC SEARCH

@bboure
Copy link
Collaborator

bboure commented Feb 12, 2022

Thank you @nvanlo !
LGTM.
Could you add a couple of tests?

@nvanlo
Copy link
Contributor Author

nvanlo commented Feb 25, 2022

Thank you @nvanlo ! LGTM. Could you add a couple of tests?

Done!

@bboure
Copy link
Collaborator

bboure commented Mar 30, 2022

ups. just realized there were two PR open for this and I just merged the other one.
#481

The solution was the same :)

I will rebase this one and merge it too as it adds tests 🚀

@bboure bboure merged commit 5bf0316 into sid88in:master Mar 30, 2022
@bboure
Copy link
Collaborator

bboure commented Mar 30, 2022

Done,

Thank you! and sorry for the mess with both PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants