Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverloaAdd parameter overloads to design-view forms #188

Merged
merged 15 commits into from
Jul 1, 2019
Merged

OverloaAdd parameter overloads to design-view forms #188

merged 15 commits into from
Jul 1, 2019

Conversation

mohanvive
Copy link
Contributor

By @PradeepaJey1 ...

Purpose

The stream and window functions doesn't show the parameter overloads along with the function name.

Goals

Add function names with parameter overloads in the stream function and window function drop-down and render the parameters according to the selected parameter overload.

Approach

  • In the drop down it displays the possible parameter loads with the function name [functionName(parameter1,parameter2)].
  • Renders the parameters which are only in the selected parameter overload.
  • If there are two or more parameter overloads with the same length, then a template will be rendered for unknown parameters as shown below. This is only rendered when an user has saved the parameters and opens the form again or when he switches from source to design view.
    image

Security checks

PradeepaJey1 and others added 12 commits June 19, 2019 10:27
@PradeepaJey1
Add parameter overloads to design-view forms
e55c7d4 
This commit will
 1. Add parameter overloads to window and stream function drop down
 2. Modifies the validation and building and mapping parameter methods to support parameter overloads
 3. Fix indentation
@PradeepaJey1
Add style
88cc392
@PradeepaJey1
Add incremental aggregators to the meta data obtained from the backend
cc0971d
@PradeepaJey1
Add incremental aggregators to the meta data obtained from the backend
c63fdee
@PradeepaJey1
Merge changes from carbon-analytics
ec2bcf0 
The changes which I have done in the carbon-analytics editor core is merged to siddhi-distribution editor core.
@PradeepaJey1
Fix for autocomplete drop downs
3935d16 
Show normal functions [time,math,etc] in the filter condition, select expressions and attributes of window and stream function
@PradeepaJey1
Add aggregate functions to stream and window function attributes
5b02e9c
@PradeepaJey1
Remove window stream handler for pattern and sequence queries
2e3365b
@PradeepaJey1
Remove hardcoded values
a514f4c 
Since incremental aggregators are obtained from the backend
@PradeepaJey1
Refactor code
6a81a4c
@PradeepaJey1
Improve the way of checking a multi-valued parameter
d12fe2c 
Instead of checking if the parameter name is "attribute", add another property called "isMultiValue" [by checking the next name in parameter overload is "..."].
@mohanvive
update Siddhi dependency version
e087f00
@CLAassistant
Copy link

CLAassistant commented Jul 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mohanvive mohanvive changed the title OverloaAdd parameter overloads to design-view formsd OverloaAdd parameter overloads to design-view forms Jul 1, 2019
@mohanvive mohanvive mentioned this pull request Jul 1, 2019
Closed
@mohanvive
Copy link
Contributor Author

Moved from #176 ...

@dnwick dnwick merged commit eaec2a3 into siddhi-io:master Jul 1, 2019
@pcnfernando pcnfernando mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwick dnwick dnwick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohanvive @CLAassistant @dnwick @PradeepaJey1