-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OverloaAdd parameter overloads to design-view forms #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will 1. Add parameter overloads to window and stream function drop down 2. Modifies the validation and building and mapping parameter methods to support parameter overloads 3. Fix indentation
The changes which I have done in the carbon-analytics editor core is merged to siddhi-distribution editor core.
Show normal functions [time,math,etc] in the filter condition, select expressions and attributes of window and stream function
Since incremental aggregators are obtained from the backend
Instead of checking if the parameter name is "attribute", add another property called "isMultiValue" [by checking the next name in parameter overload is "..."].
Moved from #176 ... |
dnwick
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By @PradeepaJey1 ...
Purpose
Goals
Approach
Security checks