Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast wipe also last 1MB of the device #109

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

smira
Copy link
Member

@smira smira commented Sep 11, 2024

This fully erases GPT partition table.

Backported from v2 branch, for Sidero Metal.

Copy link
Member

@frezbo frezbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a test also?

@smira
Copy link
Member Author

smira commented Sep 11, 2024

maybe a test also?

it should be tested already, but as this is a dead end branch, I don't think we need to put too much effort.

This fully erases GPT partition table.

Backported from v2 branch, for Sidero Metal.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira
Copy link
Member Author

smira commented Sep 11, 2024

/m

@talos-bot talos-bot merged commit 134c41b into siderolabs:main Sep 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants