fix: ignore not found ClusterMachine in the migrations

`migrateInstallImageConfigIntoGenOptions` was missing that check. Add the check and add the test. Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
siderolabs · Jun 11, 2024 · 2e64c31 · 2e64c31
1 parent a2c3802
commit 2e64c31
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/internal/backend/runtime/omni/migration/migration_test.go b/internal/backend/runtime/omni/migration/migration_test.go
@@ -1553,6 +1553,9 @@ func (suite *MigrationSuite) TestMigrateInstallImageConfigIntoGenOptions() {
 
 	for _, res := range []resource.Resource{
 		clusterMachine, clusterMachineConfig, configPatches, genOptions, clusterSecrets, lbConfig, cluster,
+		omni.NewMachineStatus(resources.DefaultNamespace, "test2"),
+		omni.NewMachineConfigGenOptions(resources.DefaultNamespace, "test2"),
+		omni.NewClusterMachineTalosVersion(resources.DefaultNamespace, "test2"),
 	} {
 		suite.Require().NoError(suite.state.Create(ctx, res, state.WithCreateOwner(res.Metadata().Owner())))
 	}

diff --git a/internal/backend/runtime/omni/migration/migrations.go b/internal/backend/runtime/omni/migration/migrations.go
@@ -1288,6 +1288,10 @@ func migrateInstallImageConfigIntoGenOptions(ctx context.Context, st state.State
 		var clusterMachine *omni.ClusterMachine
 
 		if clusterMachine, err = safe.StateGetByID[*omni.ClusterMachine](ctx, st, genOptions.Metadata().ID()); err != nil {
+			if state.IsNotFoundError(err) {
+				continue
+			}
+
 			return err
 		}