talosctl shutdown doesn't error if no talosconfig is passed.

[iMartyn]

Bug Report

I ended up in a terminal where I hadn't exported TALOSCONFIG and issued a talosctl shutdown command and nothing happened. I assumed it was an async command and waited... and waited.

Description

There should be an error message if you issue a talosctl shutdown command without either an explicit --talosconfig or a TALOSCONFIG env var.

Logs

/home/martyn [martyn@i9worker] [22:16]
> unset TALOSCONFIG

/home/martyn [martyn@i9worker] [22:16]
> talosctl shutdown -n 192.168.1.206 -e 192.168.1.206 --force

/home/martyn [martyn@i9worker] [22:16]

(no output seen on shutdown command)

Environment

• Talos version: [talosctl version --nodes <problematic nodes>] 1.5.4
• Kubernetes version: [kubectl version --short] v1.28.2
• Platform: metal-pine64

[smira]

you probably have a default talosconfig which has some (unreachable?) nodes, which talosctl is using.

talosctl config info to help, not an issue in the CLI.

[iMartyn]

No, I don't, and this is still an error that the CLI should handle, no matter what the cause!

/home/martyn [martyn@i9worker] [13:38]
> talosctl config info
no context is set

/home/martyn [martyn@i9worker] [13:38]
> talosctl shutdown -n 192.168.1.206 -e 192.168.1.206 --force

/home/martyn [martyn@i9worker] [13:39]
>

This is actually an issue in the CLI - no context should always return an error, not silently fail!

Please reopen.

[smira]

yep, looks like error reporting is broken there

[smira]

@utkuozdemir I think something is wrong here

talos/cmd/talosctl/pkg/talos/action/tracker.go

Lines 210 to 213 in ef50561

	if errors.Is(err, context.Canceled) {
	err = nil
	}

and many commands using this code path are broken same way

[utkuozdemir]

@smira Yes, seems like it. I'll submit a fix.