Fix Timestamp parsing issue #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue where APNs timestamps were being parsed incorrectly. - Removes some redundant code and tests. APNs returns a Unix time with millisecond precision. We were parsing and not accounting for the milliseconds, which was giving an invalid Time. This has been tested on APNs production gateway and now parses and returns the correct Time.
alissonsales
added a commit
that referenced
this pull request
Mar 16, 2016
Fix Timestamp parsing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APNs returns a Unix time with millisecond precision. We were parsing and not
accounting for the milliseconds, which was giving an invalid Time. This has been
tested on APNs production gateway and now parses and returns the correct Time.