-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client for GAE Environment #31
Conversation
} | ||
|
||
// Production sets the Client to use the APNs production push endpoint. | ||
func (c *GAEClient) Production() *GAEClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
receiver name c should be consistent with previous receiver name gclient for GAEClient
Awesome! Thanks for the PR. Any chance you can get the hound errors fixed and add notes on how to use to the Readme. Thanks |
Hey @sideshow, those hound issues are resolved, and I added a GAE example to the Readme. Lemme know if you think it's too detailed https://github.com/keighl/apns2/blob/498a59482d3ef45203f506193046caac6e9e2eba/README.md#app-engine |
Is there a reason why this is still pending merge after 11 months? |
Hi @benguild, at the time whilst I could run it locally I was unsure how to run it on GAE to perform end to end testing, so didn't get it merged. Since then, we have added a request context to apns2, so this code would have to be refactored slightly. I did try and refactor this myself, but got totally lost when trying to use the gcloud app engine tools with build errors and gave up. I think this is a good addition to the library. If someone wants to refactor 1 and provide instructions on how to install and run/test in production GAE then I will merge. 1: Probably need a similar file to this and this but called |
Closing this in light of the last comment. |
Hey @sideshow, thanks for this killer APNS package.
This fork adds a distinct client for using the package from within Google App Engine (classic). Annoyingly, an application can't make a general
net.Conn
, it has to use a specialappengine/socket
package.I added the
+build appengine
flag so it's only available when used inside the GAE go-sdk.Usage is like this...
Tests: