Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canned crashes when using query string parameters #98

Closed
wants to merge 3 commits into from

Conversation

targoo
Copy link
Contributor

@targoo targoo commented May 23, 2016

No description provided.

@sideshowcoder
Copy link
Owner

Thanks for looking into this, I think that might be fixed by #96 but I'll take a look later today when I merge in the other. In the meanwhile mind providing a test case int spec/... to make sure this does not break again / is fixed?

@targoo
Copy link
Contributor Author

targoo commented May 23, 2016

#96 probably going to fix it. cool. I'll work on the spec.

@sideshowcoder
Copy link
Owner

If you like to try with current master it should work, would be awesome to get a test case for it so!

@targoo
Copy link
Contributor Author

targoo commented May 23, 2016

i have added two more tests and it's all working now on master.

Finished in 0.831 seconds
66 tests, 73 assertions, 0 failures, 0 skipped

I guess we are ready for 0.3.8 ;-)

@sideshowcoder
Copy link
Owner

👍

@sideshowcoder
Copy link
Owner

merge via c246508

@sideshowcoder
Copy link
Owner

Ok 0.3.8 is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants