Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved number formatting #481

Merged
merged 12 commits into from
Nov 3, 2022
Merged

Improved number formatting #481

merged 12 commits into from
Nov 3, 2022

Conversation

zoey-kaiser
Copy link
Contributor

closes #474

I decided to use a custom regex expression over native JavaScript number functions, because the native functions only support the number type. As we do a lot of other custom formatting, the end result is always a string, resulting in them being useless. In addition to this formatting the number before we add our automatic decimal place messes up the end results, so I thought it was easier to apply the thousand commas last with regex rather then before. It also helps with the fact that we use numbers, BigNumbers and strings in some places, allowing me to simplify the amount of types the function needs to support.

Screenshot 2022-09-27 at 15 37 24

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • issue checkboxes are all addressed
  • manually checked my feature / not applicable
  • wrote tests / not applicable
  • attached screenshots / not applicable

@valiafetisov valiafetisov merged commit 94719da into main Nov 3, 2022
@valiafetisov valiafetisov deleted the improve-number-formatting branch November 3, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce thousand separators for big numbers
3 participants