typo in packet.js

[dmitryvolk]

Typo in lib/packets/packet.js:355
Packet.prototype.writeLengthCodedNumber = function(n) {
// TODO: null
if (n < 0xfb)
return this.writeInt8(n);
if (n < 0xffff) {
this.writeInt8(0xfc);
return this.writeInt16(n);
}
-------> if (this < 0xffffff) { /* should be n<0xfffffffff */
this.writeInt8(0xfd);
return this.writeInt24(n);
}
console.log(n);
console.trace();
throw "No bignumbers yet";
};

[sidorares]

Do you want to create pull request?

[dmitryvolk]

I just reviewed some parts of the code and seen the typo

[sidorares]

Well, thanks for that :)

[sidorares]

0xffffff is correct here, this < 0xffffff obviously incorrect
This code writes 3 byte-length int prefixed with 0xfd, see http://dev.mysql.com/doc/internals/en/overview.html#length-encoded-integer