Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactFiberReconciler not included with rect-dom > v16.0.0-alpha.6 #6

Closed
drom opened this issue May 19, 2017 · 5 comments
Closed

ReactFiberReconciler not included with rect-dom > v16.0.0-alpha.6 #6

drom opened this issue May 19, 2017 · 5 comments

Comments

@drom
Copy link
Contributor

drom commented May 19, 2017

Looks like your package require:

"react": "^16.0.0-alpha.5",
"react-dom": "^16.0.0-alpha.5",

react-dom 16.0.0-alpha.7 ... 12 don't include ReactFiberReconciler anymore.

Short term:

You should probably remove "^" from package.json

Long term:

We ween a way to get latest ReactFiberReconciler code. Somehow.

@sidorares
Copy link
Owner

react-dom 16.0.0-alpha.7 ... 12 don't include ReactFiberReconciler anymore.

do you know where did it go? is it in separate package now?

yes, I'm 👍 for locking versions for now

@sidorares
Copy link
Owner

sidorares commented May 19, 2017

did you have any luck running it with alpha.5 ? ( not sure how good is the current state, obviously it's far from prod ready but can't remember if it works out of the box at all ). Will try to test over weekend

@drom
Copy link
Contributor Author

drom commented May 19, 2017

Yes, your code runs with alpha.6.
I am doing custom renderer and taking your code as example. I am using alpha.6 that is last shipped with Reconciler. I haven't found Reconciler alpha-7..12 in any other NPM package from React team directly 😞

@drom
Copy link
Contributor Author

drom commented May 19, 2017

@sidorares under linux (OpenSuSe Tumbleweed) I see the window, with messy content, that is just previous screenshot. I can resize, but content is not redrawn.

@drom
Copy link
Contributor Author

drom commented May 19, 2017

Found some info here: facebook/react#9103

sidorares added a commit that referenced this issue May 20, 2017
fixed react version to 16.0.0-alpha.6 ; fixes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants