Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/radiobutton, core/checkbox): align text if line break occurs #214

Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Dec 5, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #202

What is the new behavior?

  • Align text from <input type="radio"/> and <input type="checkbox"/>

Does this introduce a breaking change?

  • Yes
  • No

Testing

Visual regression test added

@danielleroux danielleroux added type: bug Something isn't working component: core pull request affects patch version The pull request affects only patch version labels Dec 5, 2022
@danielleroux danielleroux added this to the 1.1.2 milestone Dec 5, 2022
@danielleroux danielleroux linked an issue Dec 5, 2022 that may be closed by this pull request
@danielleroux danielleroux merged commit 354db6c into main Dec 5, 2022
@danielleroux danielleroux deleted the 202-mutliline-label-breaks-checkbox-icon-placement branch December 5, 2022 10:53
@danielleroux danielleroux modified the milestones: 1.1.2, 1.2.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Mutliline label breaks checkbox icon placement
2 participants