Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): handle overflow of pills #224

Merged
merged 9 commits into from
Dec 12, 2022
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #124

What is the new behavior?

No longer has pill overflow and the input adapts to how many pills are there. If no longer has space, it goes below the pills.

image

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tested locally

@goncalosard goncalosard added type: bug Something isn't working component: core labels Dec 6, 2022
@goncalosard goncalosard linked an issue Dec 6, 2022 that may be closed by this pull request
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Dec 7, 2022
@danielleroux danielleroux added this to the 1.2.0 milestone Dec 7, 2022
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pills and the input should be on the same "line" if possible. No line break in between. Also no more than two rows at a time may be shown. Scrollbar should handle the vertical overflow. When in doubt category filter has the desired behaviour as ref.

@danielleroux danielleroux changed the title Fix/ select pills overflow fix(core/select): handle overflow of pills Dec 7, 2022
@nuke-ellington nuke-ellington self-assigned this Dec 8, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • visual regression test is missing

@danielleroux danielleroux merged commit 81aca1f into main Dec 12, 2022
@danielleroux danielleroux deleted the fix/pills-overflow branch December 12, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Select component multi selection pill overflow
3 participants