Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/page-header): add page-header #526

Merged
merged 11 commits into from
May 22, 2023
Merged

feat(core/page-header): add page-header #526

merged 11 commits into from
May 22, 2023

Conversation

michael98123
Copy link
Contributor

@michael98123 michael98123 commented May 11, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

  • page-header component is added

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux changed the title Feat/page header feat(core/page-header): add page-header May 11, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 11, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label May 11, 2023
@danielleroux danielleroux enabled auto-merge (squash) May 22, 2023 11:58
@danielleroux danielleroux merged commit cc6164e into main May 22, 2023
@danielleroux danielleroux deleted the feat/page_header branch May 22, 2023 12:34
nuke-ellington pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants