Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/menu): implement a11y features for menu and burger-menu #582

Merged
merged 7 commits into from
Jul 4, 2023

Conversation

jg0815
Copy link
Contributor

@jg0815 jg0815 commented Jun 15, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Implemented keyboard accessibility of the <ix-burger-menu> component by inserting a <button> element.
  • Implemented new property 'ixAriaLabel' for the <ix-burger-menu> component, which is required as an accessibility label for the respective icon button.
  • Set the ARIA-attributes 'aria-label' and 'aria-pressed' for the <ix-burger-menu> component.
  • Adjusted focus frame settings of the <ix-burger-menu> component via CSS.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should do the trick

packages/core/src/components/menu/burger-menu.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuke-ellington nuke-ellington merged commit b640409 into main Jul 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants