Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

957 ix menu avatar item is falsely truncated on some screens #961

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Nov 29, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: 957

What is the new behavior?

When the avatar menu is activated, it now smoothly adjusts its width to fit its largest element. This adjustment occurs regardless of the zoom level, which was identified as the actual source of the issue.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Conducting manual tests for various scenarios.

Other information

@jul-lam jul-lam linked an issue Nov 29, 2023 that may be closed by this pull request
@jul-lam jul-lam self-assigned this Nov 30, 2023
@nuke-ellington nuke-ellington merged commit d7c0152 into main Dec 5, 2023
7 checks passed
nuke-ellington pushed a commit that referenced this pull request Dec 12, 2023
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Prevents unwanted truncation when user agent zoom is active
danielleroux pushed a commit that referenced this pull request Dec 13, 2023
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Prevents unwanted truncation when user agent zoom is active
@danielleroux danielleroux added this to the 2.1.0 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-menu-avatar-item is falsely truncated on some screens
3 participants