Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react|vue): define internal components #1099

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

danielleroux
Copy link
Collaborator

๐Ÿ†• What is the new behavior?

React and Vue have to define the internal components they are not part of the generation.

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (yarn docs)
  • ๐Ÿงช Unit tests were added/updated and pass (yarn test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (yarn visual-regression)
  • ๐Ÿง Static code analysis passes (yarn lint)
  • ๐Ÿ—๏ธ Successful compilation (yarn build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 20, 2024
@danielleroux danielleroux added this to the 2.1.1 milestone Feb 20, 2024
@danielleroux danielleroux merged commit 984bb3c into main Feb 21, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/internal-components-definition branch February 21, 2024 09:31
danielleroux added a commit to danielleroux/ix that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants