Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu-category): fix unwanted behavior with active element #1102

Merged
merged 19 commits into from
Feb 26, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Feb 21, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Upon reopening the ix-menu, the ix-category appears expanded but contains no items. Only after collapsing and reopening the ix-menu-category, the menu-items become visible again.
Found a small edge case, where the category does not initially open when the menu is expanded

What is the new behavior?

  • after menu is collapsed the style of the menuItemContainer is cleared (max-height / opacity)
  • changed up the component lifecycle order (in order to initialize the menuExpanded and showItems, which is initially needed in order to show the activeElemement)

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux changed the title fix(core/897-menu): fix unwanted behavior with active element fix(core/menu-category): fix unwanted behavior with active element Feb 21, 2024
@danielleroux danielleroux added this to the 2.1.1 milestone Feb 22, 2024
@nuke-ellington nuke-ellington added the pull request affects patch version The pull request affects only patch version label Feb 23, 2024
nuke-ellington
nuke-ellington previously approved these changes Feb 23, 2024
danielleroux
danielleroux previously approved these changes Feb 26, 2024
@danielleroux danielleroux merged commit 99a9c5c into main Feb 26, 2024
6 checks passed
@danielleroux danielleroux deleted the fix/897_ix-menu branch February 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants