Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-dropdown): updated the current date when the props are changed #1139

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

ridvandmrc
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

date-dropdown can not be set outside of the component

GitHub Issue Number: #1122

What is the new behavior?

Fixed and tested

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks a unit test. Also a test case for the change was not added.

@ridvandmrc ridvandmrc force-pushed the fix/date-dropdown branch 3 times, most recently from bf36bc4 to 500b5fd Compare March 12, 2024 13:05
@ridvandmrc
Copy link
Contributor Author

Hi @nuke-ellington ,
I tested it to much but I can not reproduced

@danielleroux
Copy link
Collaborator

Hi @nuke-ellington , I tested it to much but I can not reproduced

@ridvandmrc Do you plan to update this PR? Regarding @nuke-ellington change request?

There are also some debug console log statements inside the component code, you should remove the logs there.

@ridvandmrc
Copy link
Contributor Author

Hi @nuke-ellington , I tested it to much but I can not reproduced

@ridvandmrc Do you plan to update this PR? Regarding @nuke-ellington change request?

There are also some debug console log statements inside the component code, you should remove the logs there.

Yes, I plan to update, and I remove every logs

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 4a1d6d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ridvandmrc
Copy link
Contributor Author

Hi @danielleroux ,
I updated the test cases and also I added an example for react-sample and also tested manually

danielleroux
danielleroux previously approved these changes Apr 3, 2024
danielleroux
danielleroux previously approved these changes Apr 3, 2024
.changeset/orange-insects-pull.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux merged commit 99886e0 into siemens:main Apr 3, 2024
11 checks passed
@danielleroux danielleroux deleted the fix/date-dropdown branch April 3, 2024 12:20
This was referenced Apr 3, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants