Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/menu): make behavior at breakpoint 'lg' configurable and change 'md' breakpoint menu icons #1156

Merged
merged 16 commits into from
Mar 27, 2024

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Mar 12, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

By default, the menu is expanded at the “lg” breakpoint, and there is no option to alter this behavior.

GitHub Issue Number: #892

What is the new behavior?

By default, the menu is collapsed at the “lg” breakpoint, with a newly introduced parameter “expandedNavigationMenuPreferred” governing this behavior.

Does this introduce a breaking change?

  • Yes
  • No

To revert the new default behavior, the newly added parameter “expandedNavigationMenuPreferred” must be set to true.

Testing

Manual tests.

Other information

@jul-lam jul-lam self-assigned this Mar 12, 2024
packages/core/src/components/menu/test/menu.ct.ts Outdated Show resolved Hide resolved
packages/core/src/components/menu/menu.tsx Outdated Show resolved Hide resolved
packages/core/src/components/menu/menu.tsx Outdated Show resolved Hide resolved
packages/core/src/components/menu/menu.tsx Outdated Show resolved Hide resolved
@jul-lam jul-lam changed the title feat(core/menu): make behavior at breakpoint lg configurable feat(core/menu): make behavior at breakpoint 'lg' configurable and change 'md' breakpoint menu icons Mar 13, 2024
Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 472a29a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Minor
@siemens/ix-aggrid Patch
@siemens/ix-angular Minor
@siemens/ix-react Minor
@siemens/ix-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux merged commit 1d27804 into main Mar 27, 2024
11 checks passed
@danielleroux danielleroux deleted the feat/menu-breakpoint branch March 27, 2024 13:41
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
@danielleroux danielleroux added this to the 2.2.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants