fix(core/select): non string values for the "value" prop of select-items are not working #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jul-lam
changed the title
jul-lam
changed the title
nuke-ellington
requested changes
Mar 13, 2024
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
nuke-ellington
previously approved these changes
Mar 13, 2024
nuke-ellington
added
the
pull request affects patch version
🦋 Changeset detectedLatest commit: f680d42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danielleroux
approved these changes
Mar 27, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn test) were run locally and passedyarn visual-regression) were run locally and passednpm lint) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The item is not selectable if the value prop of the item is a non string value.
GitHub Issue Number: #1076
What is the new behavior?
The item is now also selectable if the value prop of the item is a non string value.
Does this introduce a breaking change?
Testing
Manual tests.
Other information
No tests were added, since the value prop will be of type string in future.